Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reference point resources (ref-point migration 1/5) #997

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

tobous
Copy link
Member

@tobous tobous commented May 23, 2020

[INTERNAL][I] Introduce new resource implementation

Introduces the new reference point based resource implementation. The
implementation is based on the existing implementation that was then
simplified and adjusted to use reference points.

The new implementation is not used anywhere yet.

Marks the old resource implementations as deprecated.

[INTERNAL][I] Adjust VirtualFileConverter to support new resource impls

Adds methods for the new reference point based resource implementations
to VirtualFileConverter.

Marks the old methods as deprecated.

@tobous tobous added the Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) label May 23, 2020
@tobous tobous self-assigned this May 23, 2020
@tobous tobous changed the title Introduce reference point resources Introduce reference point resources (ref-point migration 1/5) May 23, 2020
@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from ba1aa27 to 91c6e6a Compare May 25, 2020 11:35
@tobous tobous requested a review from stefaus May 26, 2020 17:45
@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from 91c6e6a to 7341a73 Compare May 27, 2020 23:35
@tobous
Copy link
Member Author

tobous commented May 27, 2020

Adjust exists() check to first check whether the reference point the resource is based on exists.

@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from 7341a73 to e1c9310 Compare May 27, 2020 23:53
@tobous
Copy link
Member Author

tobous commented May 27, 2020

Rebased onto current master. Fixed minor issues due to merging #1005.

@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from e1c9310 to 4a5b4b4 Compare May 28, 2020 00:08
@tobous
Copy link
Member Author

tobous commented May 28, 2020

Adjusted implementation to require non-empty paths for resources. This was done to avoid issues with empty paths allowing the creation of IFolder handles for the reference point resource. Such resources would behave unexpectedly when certain methods (like getName()) were called and would allow deleting the reference point resource.

m273d15
m273d15 previously approved these changes May 28, 2020
@tobous tobous added the Breaks Compatibility Change breaking compatibility with previous releases label May 28, 2020
@tobous tobous added this to the Saros/I Release NEXT milestone May 28, 2020
@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from 4a5b4b4 to 7b3126f Compare May 29, 2020 16:40
@tobous
Copy link
Member Author

tobous commented May 29, 2020

Fixed a C&P error: IntellifFolderImplV2 used the given path for creating a folder child resource instead of first appending it to the relative path of the folder.

m273d15
m273d15 previously approved these changes Jun 3, 2020
Introduces the new reference point based resource implementation. The
implementation is based on the existing implementation that was then
simplified and adjusted to use reference points.

The new implementation is not used anywhere yet.

Marks the old resource implementations as deprecated.
Adds methods for the new reference point based resource implementations
to VirtualFileConverter.

Marks the old methods as deprecated.
@tobous tobous force-pushed the pr/intellij/introduce-reference-point-resources branch from 7b3126f to 44c769d Compare June 9, 2020 12:39
@tobous
Copy link
Member Author

tobous commented Jun 9, 2020

Rebased onto current master without any interaction.

@saros-infrastructure
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- intellij/src/saros/intellij/filesystem/IntellijFolderImplV2.java  9
- intellij/src/saros/intellij/filesystem/IntellijResourceImplV2.java  5
- intellij/src/saros/intellij/filesystem/IntellijReferencePointImpl.java  7
- intellij/src/saros/intellij/filesystem/IntellijFileImplV2.java  8
         

See the complete overview on Codacy

@tobous tobous merged commit c606a48 into master Jun 9, 2020
@tobous tobous deleted the pr/intellij/introduce-reference-point-resources branch June 9, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) Breaks Compatibility Change breaking compatibility with previous releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants