-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce reference point resources (ref-point migration 1/5) #997
Introduce reference point resources (ref-point migration 1/5) #997
Conversation
intellij/src/saros/intellij/filesystem/IntellijFolderImplV2.java
Outdated
Show resolved
Hide resolved
intellij/src/saros/intellij/filesystem/IntellijReferencePointImpl.java
Outdated
Show resolved
Hide resolved
ba1aa27
to
91c6e6a
Compare
91c6e6a
to
7341a73
Compare
Adjust |
7341a73
to
e1c9310
Compare
Rebased onto current master. Fixed minor issues due to merging #1005. |
e1c9310
to
4a5b4b4
Compare
Adjusted implementation to require non-empty paths for resources. This was done to avoid issues with empty paths allowing the creation of |
4a5b4b4
to
7b3126f
Compare
Fixed a C&P error: |
Introduces the new reference point based resource implementation. The implementation is based on the existing implementation that was then simplified and adjusted to use reference points. The new implementation is not used anywhere yet. Marks the old resource implementations as deprecated.
Adds methods for the new reference point based resource implementations to VirtualFileConverter. Marks the old methods as deprecated.
7b3126f
to
44c769d
Compare
Rebased onto current master without any interaction. |
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- intellij/src/saros/intellij/filesystem/IntellijFolderImplV2.java 9
- intellij/src/saros/intellij/filesystem/IntellijResourceImplV2.java 5
- intellij/src/saros/intellij/filesystem/IntellijReferencePointImpl.java 7
- intellij/src/saros/intellij/filesystem/IntellijFileImplV2.java 8
See the complete overview on Codacy |
[INTERNAL][I] Introduce new resource implementation
Introduces the new reference point based resource implementation. The
implementation is based on the existing implementation that was then
simplified and adjusted to use reference points.
The new implementation is not used anywhere yet.
Marks the old resource implementations as deprecated.
[INTERNAL][I] Adjust VirtualFileConverter to support new resource impls
Adds methods for the new reference point based resource implementations
to VirtualFileConverter.
Marks the old methods as deprecated.