Add integration tests #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Also clean up python specifiers Signed-off-by: Dan Ryan <dan@danryan.co>
- Also add magic methods to MetaSet object - Super fast and efficient now due to set comparisons - Old method had sometimes thousands of the same pyspecs - This consolidates as it builds Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co> Add set operations and comparison methods to metasets Signed-off-by: Dan Ryan <dan@danryan.co> Add abstract extraction methods for marker cleanup Signed-off-by: Dan Ryan <dan@danryan.co> Add intersection method for PySpecs and smarter unions and creation Signed-off-by: Dan Ryan <dan@danryan.co> Simplify and cleanup metadata implementation Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
frostming
force-pushed
the
add-tests-frost
branch
from
b8e5f31
to
674f9b7
Compare
Codecov Report
@@ Coverage Diff @@
## add-tests #66 +/- ##
============================================
Coverage ? 54.72%
============================================
Files ? 42
Lines ? 2701
Branches ? 475
============================================
Hits ? 1478
Misses ? 1108
Partials ? 115
Continue to review full report at Codecov.
|
|
Creating virtualenv for every test case is a big performance killer in testing. |
frostming
force-pushed
the
add-tests-frost
branch
from
436a30e
to
6517a33
Compare
|
Whoa, after mocking installation, the time cost is reduced by 60%! |
frostming
force-pushed
the
add-tests-frost
branch
from
c55ee5c
to
51542c8
Compare
added 12 commits
September 28, 2019 22:20
Before change, metasets have a large number of duplicate items. and the size grows exponentially
frostming
force-pushed
the
add-tests-frost
branch
from
b332052
to
2682a8e
Compare
|
I am not apt to make huge PRs, so if the review is done we can start merging stuff. No need to have a full test suite at this point. Especially there are some bugfixes that are worth merging into the master. Do we need to cherry-pick? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.