Migrate options to Vue and go more community driven #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
force-pushed
the
enh/noid/options-to-vue
branch
from
d70a4ce
to
0c744e8
Compare
This commit makes several improvements. It migrates the options page to Vue, changes the author field and copyrights to include The SAS PES Authors, deduplicates some code, and adds some missing information/fixes to the README. Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
enh/noid/options-to-vue
branch
from
0c744e8
to
06a4bec
Compare
Suhas-13
approved these changes
Mar 22, 2020
Mozilla's Webextension Polyfill throws an error when run in the unit test environment. This has been fixed by mocking the browser environment using browser-env and having a global `chrome` object. Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
enh/noid/options-to-vue
branch
from
8cddfc0
to
addd032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the options page to Vue and changes the author field to include The SAS PES Authors. Also, a bit of code deduplication never hurts.
Also mentioned the addition of cumulative GPA calculation to the README.