Refactor extend. #143
Merged
Refactor extend. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to share more logic if selector lists overlap.
Also rename it Extension.
Rather than extending each selector individually and unifying them with the un-extended rest, this extends everything in one step and unifies in the next.
This seems to be substantially faster, at least on the VM.
This means that extensions that match but fail to unify are valid, but we think that's okay; see sass/sass#2250.
A simple selector's source specificity should only come from its original complex selector, and shouldn't be modified by extensions.
This allows us to support cases where an extension's extender is itself extended after it's declared but before it's used.
nex3
pushed a commit
that referenced
this pull request
May 10, 2023
Bumps [sass_api](https://github.com/sass/dart-sass) from 4.2.1 to 5.0.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass_api/4.2.1...sass_api/5.0.0) --- updated-dependencies: - dependency-name: sass_api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
May 16, 2023
* main: (162 commits) Move source and test files to namespaced subdirectories Update Dart Sass version and release Update Dart Sass version and release Update Dart Sass version and release Update Dart Sass version and release Update Dart Sass version and release Update Dart Sass version and release Revert "Remove workaround for dart-lang/setup-dart#59 (sass#151)" (sass#153) Update Dart Sass version and release Update Dart Sass version and release Remove workaround for dart-lang/setup-dart#59 (sass#151) Update Dart Sass version and release Update Dart Sass version and release Fix qemu releases (sass#149) Update Dart Sass version and release Bump sass_api from 4.2.1 to 5.0.0 (sass#143) Bump meta from 1.8.0 to 1.9.0 (sass#144) Bump grinder from 0.9.2 to 0.9.3 (sass#145) Add missing setup-dart step in qemu release (sass#147) Use buf instead of protoc to compile protobufs (sass#146) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes many outstanding issues with extend. Dart Sass still doesn't
always generate the same output as Ruby Sass, but it should have correct
semantics. In particular, as of this commit it should obey the two laws
laid out in sass/sass#324.
See sass/sass-spec#1126