New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/support partial #27

Merged
merged 3 commits into from Sep 30, 2014

Conversation

Projects
None yet
4 participants
@item4
Contributor

item4 commented Sep 29, 2014

sassutils/builder.py do not support SCSS partial import because it try compile every file even partial files.

I just fixed that no complie with partial files and added test case.

@coveralls

This comment has been minimized.

coveralls commented Sep 29, 2014

Coverage Status

Coverage increased (+0.15%) when pulling b4745bb on item4:bugfix/support-partial into 02d4d96 on dahlia:python.

@@ -46,6 +46,9 @@ def build_directory(sass_path, css_path, _root_sass=None, _root_css=None):
for name in os.listdir(sass_path):
sass_fullname = os.path.join(sass_path, name)
if SUFFIX_PATTERN.search(name) and os.path.isfile(sass_fullname):
if name[0] == '_':
"""If file is partial file. do not compile"""

This comment has been minimized.

@miaekim

miaekim Sep 29, 2014

why don't you use # comment?

@coveralls

This comment has been minimized.

coveralls commented Sep 30, 2014

Coverage Status

Coverage increased (+0.15%) when pulling 09c721a on item4:bugfix/support-partial into 02d4d96 on dahlia:python.

@dahlia dahlia merged commit 09c721a into sass:python Sep 30, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

dahlia added a commit that referenced this pull request Sep 30, 2014

@item4 item4 deleted the item4:bugfix/support-partial branch Sep 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment