Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building with make does not work if g++ is not installed #2707

Closed
glebm opened this issue Aug 2, 2018 · 0 comments
Closed

Building with make does not work if g++ is not installed #2707

glebm opened this issue Aug 2, 2018 · 0 comments

Comments

@glebm
Copy link
Contributor

glebm commented Aug 2, 2018 •
edited
Loading

I only have clang, no g++ on my system. However, when building this with make, it tries to invoke g++ and fails (sassc-ruby builds with make during install).

This is because of:

libsass/Makefile

Lines 2 to 3 in edd29a2

CC ?= gcc
CXX ?= g++

Perhaps these should instead default to:

CC       ?= cc
CXX      ?= c++

These are aliases on Debian and Ubuntu for the default c/cpp compilers, but I'm not sure about other systems. What do you think?

Worked around by setting these environment variables before installing.
glebm added a commit to glebm/libsass that referenced this issue Aug 6, 2018
@glebm
Update make CC and CXX defaults for wider compat
ed4b735 
Fixes sass#2707
@glebm glebm mentioned this issue Aug 6, 2018
Merged
xzyfer pushed a commit that referenced this issue Sep 12, 2018
@glebm @xzyfer
Update make CC and CXX defaults for wider compat
ad30194 
Fixes #2707
glebm added a commit to glebm/sassc-ruby that referenced this issue Nov 17, 2018
@glebm
Update libsass to master to fix :not issue
8a708b3 
Updates libsass to master to incorporate fixes for:

1. The :not selector. sass#91 sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also changes the location of libsass.so from ext/ to lib/ (fixes sass#95).
glebm added a commit to glebm/sassc-ruby that referenced this issue Nov 17, 2018
@glebm
Update libsass to master to fix several issues
d849852 
Updates libsass to master to incorporate fixes for:

1. The :not selector. sass#91 sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also changes the location of libsass.so from ext/ to lib/ (fixes sass#95).
@glebm glebm mentioned this issue Nov 17, 2018
Merged
glebm added a commit to glebm/sassc-ruby that referenced this issue Nov 17, 2018
@glebm
Update libsass to master to fix several issues
412d15b 
Updates libsass to master to incorporate fixes for:

1. The :not selector. sass#91 sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:

1. Changes the location of libsass.so from ext/ to lib/. Fixes sass#95
2. No longer tries to run `nmake` on Windows (libsass Makefile is
   compatible with GNU Make only).
glebm added a commit to glebm/sassc-ruby that referenced this issue Nov 17, 2018
@glebm
Update libsass to master + other fixes
bf4296c 
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue Nov 17, 2018
@glebm
Update libsass to master + other fixes
b0b9592 
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
96c02f3 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
9b8ae66 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
91b115f 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
79dcdff 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
d2d6fb0 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
f84f75a 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 5, 2019
@glebm
Update libsass to master + other fixes
1f7d2dd 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 8, 2019
@glebm
Update libsass to master + other fixes
e1dbffe 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 8, 2019
@glebm
Update libsass to master + other fixes
efdd4c6 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 8, 2019
@glebm
Update libsass to master + other fixes
0ea99d1 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm added a commit to glebm/sassc-ruby that referenced this issue May 8, 2019
@glebm
Update libsass to master + other fixes
3c3344f 
Updates libsass to master to incorporate fixes for:

1. The :not selector. Fixes sass#91. sass/libsass#2697
2. Default precision changed to 10. sass/libsass#2716
3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707
4. Building on Linux and Solaris. sass/libsass#2720

Also:
1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18.
2. Fixes `load_paths` separator on Windows. Fixes sass#93.
3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glebm