Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Replace "request" by "got" #1358

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Replace "request" by "got" #1358

merged 1 commit into from
Jan 27, 2016

Conversation

zckrs
Copy link
Contributor

@zckrs zckrs commented Jan 26, 2016

  • Less dependency
  • Use only stream

I use got@5 because node-sass support NodeJS 0.10 and 0.12.

/cc @sindresorhus

Graph deps compare Request Graph vs Got Graph

* Less dependency
* Use only stream
@xzyfer
Copy link
Contributor

xzyfer commented Jan 26, 2016

I'm not thrilled about being pinned to an older version a library, although it does appear to still be receiving update. NodeJS < 4 support is not going away time soon. Our most used version is 0.12.

@xzyfer xzyfer added this to the next.minor milestone Jan 26, 2016
@sindresorhus
Copy link
Contributor

// @floatdrop

@floatdrop
Copy link

@xzyfer got 5.x will receive updates until Node.JS 0.10 is deprecated.

lgtm.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 27, 2016

Thanks for the clarification @floatdrop

@xzyfer xzyfer self-assigned this Jan 27, 2016
xzyfer added a commit that referenced this pull request Jan 27, 2016
@xzyfer xzyfer merged commit 92811c6 into sass:master Jan 27, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Apr 21, 2016

We need to revert this because need to support proxies. I didn't realise proxies weren't supported at the time, my mistake.

@zckrs
Copy link
Contributor Author

zckrs commented Apr 21, 2016

Sorry about that but got doesn't support proxy @sindresorhus?

@sindresorhus
Copy link
Contributor

Not yet built-in, but you can easily add it: https://github.com/sindresorhus/got#proxies

@xzyfer
Copy link
Contributor

xzyfer commented Apr 21, 2016

tunnel current has failing tests for node 0.10 and 0.12 which are important to us. It may still work but this doesn't inspire confidence and users are currently experiencing issues.

@xzyfer xzyfer modified the milestone: next.minor Sep 4, 2016
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Use GNUmakefile.am not to conflict with static Makefile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants