This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
chore: update request package
#2170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks node < 4 support and would be a very big major change for us.
This will happen in version 5.
…On 29 Nov. 2017 11:21 pm, "Evilebot Tnawi" ***@***.***> wrote:
Fix security issues (see https://github.com/request/
request/blob/master/CHANGELOG.md#v2810-20170309)
------------------------------
You can view, comment on, or merge this pull request online at:
#2170
Commit Summary
- chore: update `request` package
File Changes
- *M* package.json
<https://github.com/sass/node-sass/pull/2170/files#diff-0> (2)
Patch Links:
- https://github.com/sass/node-sass/pull/2170.patch
- https://github.com/sass/node-sass/pull/2170.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2170>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWHKRvIhBazwp3BCu47nosPwvsIKgks5s7UxDgaJpZM4Qu3-9>
.
|
|
Just checking: since this is now being halted on downstream projects by NSP, when will version 5 be released? Support for Node 4 as an LTS ends in basically 2 months (https://github.com/nodejs/Release#release-schedule), meaning that blocking the dependency update to cater for a soon-to-be-deprecated version just doesn't seem valid. The lowest active LTS is 6.x, that should be the minimum not true? |
martin-corevski
added a commit
to martin-corevski/webpack-basics
that referenced
this pull request
Apr 27, 2018
Almost fixed hoek package, dependency of hawk -> request -> node-sass request/request#2874 Waiting for version 5 of node-sass sass/node-sass#2170
NBakaev
added a commit
to NBakaev/angular-essential-select
that referenced
this pull request
May 5, 2018
|
just my two cents: node-sass 4.9 requires node-gyp 3.3 and node-gyp 3.3 that also requires hawk 4.2.1 with the result that node-sass 4.9 already requires node >= 4 - so I don't understand the point in blocking an update because it is breaking node 0.10 support 😕 |
|
node-gyp is only used if the binary download fails, which is done through request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix security issues (see https://github.com/request/request/blob/master/CHANGELOG.md#v2810-20170309)