Version 5.0

[xzyfer]

See #2111

Features

• Reduce Node version support to Active LTS and Current (@xzyfer) *BREAKING*
• Replace Gaze with Chokidar (@xzyfer)
• Compile on watch by default (@xzyfer) *BREAKING*
• Stop watching and compiling .css files (@xzyfer) *BREAKING*
• Allow fallback to local compile on unsupported environments
• LibSass 3.6

Misc

• Update dependencies (@xzyfer) *BREAKING*
• ES6-ify where it improves readability *BREAKING*
• Remove deprecated process.sass API (@xzyfer) *BREAKING*
• Set engines to supported Node versions ([v5] Indicate the supported Node.js version in package.json #2316, @realityking) *BREAKING*
• Remove some Node < 6 work arounds ([v5] Remove workarounds for old Node.js versions #2317, @realityking) *BREAKING*
• Remove Object.assign polyfill ([v5] Drop lodash.assign in favor of the native Object.assign #2318, @realityking)
• Remove async-foreach dependency (@xzyfer)

Maybe

• Official electron support

[xzyfer]

@nschonni @saper I've created the next-major branch. The plan is to merge all the 5.0 milestone changes into that branch so that we can start cutting 5.0 betas with the latest libsass, and trial N-API.

[saper]

Is N-API here ready for the prime time? I think have already big changes in, let's not put too many...

[xzyfer]

Lots of extensions have moved over. We had issues with node 9 initially but with node >= 10 ci seems happy.

…

On Sat, 9 Nov 2019, 10:29 am Marcin Cieślak, ***@***.***> wrote: Is N-API here ready for the prime time? I think have already big changes in, let's not put too many... — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWFFMI6CA2BTB5NL4BLQSXY4PA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTVERA#issuecomment-552030788>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWBS2P73OAXH2UB2SJLQSXY4PANCNFSM4EYTBPSQ> .

[saper]

Sure the code works now - the question is can we release a new binding file with a new version number when the libuv gets upgraded (it gets upgraded pretty often, but rarely breaks compatibility).

I wrap my head around this: https://nodejs.org/api/n-api.html#n_api_implications_of_abi_stability

We include <uv.h> in src/callback_bridge.h and we need it. That probably means we have to check our compatibility with libuv via some other means.

[xzyfer]

N-API has async APIs we can use instead of direct libuv
https://nodejs.org/api/n-api.html#n_api_simple_asynchronous_operations

[saper]

Yes, we should switch to that. Looks like a non-trivial rewrite to me :(

[xzyfer]

Definitely. I think I considered before and ruled it out. I need to refamiliarise myself with the implementation.

…

On Sun, 10 Nov 2019, 12:30 am Marcin Cieślak, ***@***.***> wrote: Yes, we should switch to that. Looks like a non-trivial rewrite to me :( — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWGIPCATJ2MCMSE7J4DQS23OPA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUGF3I#issuecomment-552100589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWCYV3YFTNTKG44WXQDQS23OPANCNFSM4EYTBPSQ> .

[saper]

But that means to me we should drop it if we want to kick 5.0 out of the door quickly. Sorry if I am feeling pushy and not contributing enough... :(

[xzyfer]

I appreciate your feedback. Node 8 will is in Jan. I agreed we need to understand the trade offs of uv's abi, and do our best to limit the impact. I'll keep digging into it.

…

On Sun, 10 Nov 2019, 12:36 am Marcin Cieślak, ***@***.***> wrote: But that means to me we should drop it if we want to kick 5.0 out of the door quickly. Sorry if I am feeling pushy and not contributing enough... :( — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWHXEGUQQHFS3R4C6ZLQS24FDA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUGJXA#issuecomment-552101084>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWG4FO7U4J6BPZKSNN3QS24FDANCNFSM4EYTBPSQ> .

[saper]

Sure, I'll have a look at it too.