Install: Bind to specific binaries commit #516
Conversation
| @@ -36,9 +36,14 @@ function fetch(name) { | |||
| strip: 1 | |||
| }); | |||
|
|
|||
| var commitHash = JSON.parse(fs.readFileSync(path.join(__dirname, '..', 'package.json'), 'utf8')).binaries; | |||
There was a problem hiding this comment.
require('../package.json').binaries
|
Why don't we tag them instead of using the commit hash? |
|
How would the tag URL work? |
|
Is it a branch name or tag? I can't access this for example: https://raw.github.com/sass/node-sass/v1.1/package.json |
|
That's a tag. Like this for example https://raw.githubusercontent.com/sass/node-sass/v1.1.4/package.json. |
|
Ah that's neat! But does it make sense? We would always have to make a release on binaries just for sake of this line. |
|
Wrong tagging. Should be semver and mirror this repo. I've fixed it. |
|
Check now. |
|
BTW, we don't need 1.1.5. This should be 1.2. Why are you keep changing on node-sass-binaries? |
Install: Bind to specific binaries commit
|
Goooodie! We don't need to do a release on node-sass-binaries. Just tag it locally and push |
|
Shall I 🚢? |
|
🚢 it |
|
Or wait. Seems like 5919c6f broke something. |
|
I just published it and yes, it appears to be broken, or at least building from source and not using any of the binaries 😦 |
|
Should be fixed now. |
|
|
de63cd6. Make sure you have to ../src/sass_context_wrapper.h:1:36: fatal error: libsass/sass_interface.h: No such file or directory` |
|
@kevva can you explain that about libsass? Where was that change made and how do I reproduce it? |
|
There's no change done to it. But you doesn't seem to have it locally in the |
|
Seems to work fine now. Building too. 👍 |
|
Yeah except the linux x64 binding doesn't work on heroku, got a meeting now but will try a binary from my VM later this afternoon. |
* Built on CentOS 5.11 with GCC 4.4.7. * Credit goes to @mgreter based on: sass/node-sass#516 (comment).
Since we can't get file from tag via URL and it doesn't make sense to; release a node-sass-binaries, download a tarball and extract specific binary file, I think adding
node-sass-binariescommit hash to package.json before releasing the npm is easy./cc @kevva