Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangyp required at runtime for post-install from build.js #714

Closed
wants to merge 1 commit into from
Closed

pangyp required at runtime for post-install from build.js #714

wants to merge 1 commit into from

Conversation

hmalphettes
Copy link

➜  tmp  npm i node-sass
|
> node-sass@2.0.1 install /Users/hugues/proj/tmp/node_modules/node-sass
> node scripts/install.js

Can not download file from https://raw.githubusercontent.com/sass/node-sass-binaries/v2.0.1/darwin-x64-iojs-1.4/binding.node

> node-sass@2.0.1 postinstall /Users/hugues/proj/tmp/node_modules/node-sass
> node scripts/build.js

module.js:322
    throw err;
          ^
Error: Cannot find module '/Users/hugues/proj/tmp/node_modules/node-sass/node_modules/pangyp/bin/node-gyp'
    at Function.Module._resolveFilename (module.js:320:15)
    at Function.Module._load (module.js:262:25)
    at Function.Module.runMain (module.js:485:10)
    at startup (node.js:112:16)
    at node.js:863:3
Build failed

pangyp is assumed to be installed as a local module by script/build.js.
But it is only installed for development.

This PR fixes that issue.

@hmalphettes hmalphettes changed the title pangyp required as post-install from build.js pangyp required at runtime for post-install from build.js Feb 27, 2015
@hmalphettes
Copy link
Author

Well, when I am using the patched module with iojs-v1.4.1 from my main application pangyp behaves strangely.
I ended-up reverting back to using the standard-node-gyp and all is well:
https://github.com/hmalphettes/node-sass/commit/5a113952bf517ebb96f50204431b8f2d8844500d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant