New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "build: Adds win_delay_hook so iojs runs with alias." #942
Conversation
As an alternative, what about adding iojs.exe or atomwhateceritscallednow.exe binaries to the matrix? |
The troubleshooting guide has an issue for the iojs.exe issue. I don't think there is an alternative since Windows installs atm are broken. |
Reverting this makes them less broken. |
@@ -2,7 +2,6 @@ | |||
'targets': [ | |||
{ | |||
'target_name': 'binding', | |||
'win_delay_load_hook': 'true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this line
It has no side effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This reverts commit 579baf3.
Windows install are not broken. |
More specifically, they're broken for Windows users without git installed. |
This PR reverts commit 579baf3.
This is causing a lot of issues for people trying to install node-sass on windows. Two main culprits are proxy blocking git ports, or the local system not having git installed.
Fixes #939.
Fixes #933.
Closed #931.