Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: Adds win_delay_hook so iojs runs with alias." #942

Closed
wants to merge 1 commit into from

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented May 9, 2015

This PR reverts commit 579baf3.

This is causing a lot of issues for people trying to install node-sass on windows. Two main culprits are proxy blocking git ports, or the local system not having git installed.

Fixes #939.
Fixes #933.
Closed #931.

@saper
Copy link
Member

saper commented May 9, 2015

As an alternative, what about adding iojs.exe or atomwhateceritscallednow.exe binaries to the matrix?

@xzyfer
Copy link
Contributor Author

xzyfer commented May 9, 2015

The troubleshooting guide has an issue for the iojs.exe issue. I don't think there is an alternative since Windows installs atm are broken.

@xzyfer
Copy link
Contributor Author

xzyfer commented May 9, 2015

Reverting this makes them less broken.

@@ -2,7 +2,6 @@
'targets': [
{
'target_name': 'binding',
'win_delay_load_hook': 'true',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this line
It has no side effect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@am11
Copy link
Contributor

am11 commented May 9, 2015

Windows install are not broken.
We don't need alternative solution to the problem which tons of people discussed in io.js issue tracker and devised this working tangible solution.
Secondly, until we hear back from @rvagg regarding rvagg/archived-pangyp#5, we can revert back pangyp to npm version. For the release, I will build the binaries locally with the delay load fix. So the issue is very much contained and effect only those who use io.js on windows && manually building node-sass binary.

@xzyfer
Copy link
Contributor Author

xzyfer commented May 9, 2015

More specifically, they're broken for Windows users without git installed.

@xzyfer xzyfer closed this in #943 May 9, 2015
@xzyfer xzyfer modified the milestones: next.patch, v3.1.0 May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation issue installation problem
3 participants