Add get_annotations() to CVPy #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kybowm
reviewed
Dec 22, 2022
kybowm
reviewed
Dec 22, 2022
|
Looks good to me, @courtneyambrozic ! I left one non-critical suggestion. |
ptelang
reviewed
Dec 22, 2022
|
Looks good to me, @courtneyambrozic! Thanks for the edits! |
|
Hi @ptelang, please let me know if you have any more suggestions! Thanks! |
ptelang
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Hi @courtneyambrozic, Thanks for addressing the comments. Some of the comments are marked resolved, however, I don't see code changes corresponding to them.
I don't need to see the changes again. You can merge the PR after you address the remaining comments. Thanks.
|
Sorry about that, @ptelang, I'm not sure where those changes disappeared to. I updated the files and am going to squash & merge. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the get_annotations() API to CVPy. Two tests are added to test classification and object detection CVAT projects.