Skip to content

v1.9.1 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 4, 2023
Merged

v1.9.1 #161

merged 32 commits into from
May 4, 2023

Conversation

smlindauer
Copy link
Collaborator

Various bug fixes and patches for 1.9.0

djm21 and others added 28 commits April 21, 2023 11:30
@smlindauer smlindauer requested a review from djm21 April 28, 2023 17:15
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #161 (0d9abb6) into master (f401981) will decrease coverage by 0.15%.
The diff coverage is 52.50%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   78.51%   78.36%   -0.15%     
==========================================
  Files          54       54              
  Lines        5235     5255      +20     
==========================================
+ Hits         4110     4118       +8     
- Misses       1125     1137      +12     
Flag Coverage Δ
integration 55.71% <27.50%> (-0.07%) ⬇️
unit 62.51% <47.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sasctl/pzmm/import_model.py 85.98% <ø> (ø)
src/sasctl/pzmm/pickle_model.py 68.18% <38.46%> (-16.44%) ⬇️
src/sasctl/pzmm/write_json_files.py 67.89% <56.00%> (+0.12%) ⬆️
src/sasctl/pzmm/write_score_code.py 98.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@djm21 djm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major to look at, just a few minor tweaks

@smlindauer smlindauer merged commit 0e42c44 into master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants