Use newline='' for csv.writer #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hmm... This fixes the EDIT: It's because I changed the wrong function... 😮 Fixed now. |
Fixes saulpw#1362 According to the docs for csv.writer: > If csvfile is a file object, it should be opened with newline='' > https://docs.python.org/3/library/csv.html#csv.writer Additionally: > If newline='' is not specified, newlines embedded inside quoted fields will > not be interpreted correctly, and on platforms that use \r\n linendings on > write an extra \r will be added. It should always be safe to specify > newline='', since the csv module does its own (universal) newline handling. > https://docs.python.org/3/library/csv.html#id3 This commit adds `newline=None` as a keyword argument for `open_text` in `path.py`. It then uses this new keyword argument when opening a file for writing in `loaders/csv.py`
|
Thanks so much for tracking this down and fixing it, @daviewales! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362
According to the docs for csv.writer:
Additionally:
This commit adds
newline=Noneas a keyword argument foropen_textinpath.py. It then uses this new keyword argument when opening a filefor writing in
loaders/csv.py