[sas-] make XptSheet rows be list instead of tuple #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
XptSheetinloaders/sas.pyproduces rows that are tuples.That's undesirable because as @saulpw pointed out recently, rows can't be edited if they are tuples. And also because selecting one row may cause other rows to be selected if they are interned tuples, that have the same values and ID. This PR converts the tuples to lists.
to reproduce:
pip install xport==2.0.2download brakes.xpt
vd brakes.xptthen inspect any row with^Yforpyobj-row, the status bar will saytuple.