Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update kotlin core dependencies to v1.8.20 #518

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 3, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.kotlin.plugin.serialization (source) 1.8.10 -> 1.8.20 age adoption passing confidence
org.jetbrains.kotlin.multiplatform (source) 1.8.10 -> 1.8.20 age adoption passing confidence
org.jetbrains.kotlin:kotlin-serialization (source) 1.8.10 -> 1.8.20 age adoption passing confidence
org.jetbrains.kotlin:kotlin-gradle-plugin (source) 1.8.10 -> 1.8.20 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   10m 44s ⏱️ -4s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 863d904. ± Comparison against base commit fb5ef84.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✔️ ±0   14m 59s ⏱️ + 3m 43s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 863d904. ± Comparison against base commit fb5ef84.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

218 tests   - 27   194 ✔️  - 27   11m 36s ⏱️ - 1m 13s
  42 suites  -   6     22 💤  -   2 
  42 files    -   6       2 +  2 

For more details on these failures, see this check.

Results for commit 863d904. ± Comparison against base commit fb5ef84.

This pull request removes 27 tests.
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ basic warn-plugin test with exactWarningsMatch = false[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ basic warn-plugin test with ignoreTechnicalComments=true[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ basic warn-plugin test[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ regression - test resources in multiple directories[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test - multiple warnings and ignore technical comments[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test - multiple warnings and no line-col[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test - multiple warnings[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test exception[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test for all mods[mingwX64]
com.saveourtool.save.plugin.warn.WarnPluginTest ‑ warn-plugin test for batchSize[mingwX64]
…

♻️ This comment has been updated with latest results.

@nulls nulls self-assigned this Apr 3, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Apr 3, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@nulls nulls enabled auto-merge (squash) April 3, 2023 08:27
@kgevorkyan
Copy link
Member

perform :kotlinUpgradeYarnLock

shouldn't it be automatically? @nulls

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #518 (863d904) into main (fb5ef84) will increase coverage by 1.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #518      +/-   ##
============================================
+ Coverage     47.19%   48.45%   +1.26%     
- Complexity      159      164       +5     
============================================
  Files            53       53              
  Lines          1873     1882       +9     
  Branches        318      313       -5     
============================================
+ Hits            884      912      +28     
+ Misses          857      841      -16     
+ Partials        132      129       -3     
Flag Coverage Δ
unittests 48.45% <ø> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls
Copy link
Member

nulls commented Apr 3, 2023

shouldn't it be automatically? @nulls

we have it as a separate task in save-cloud, but we don't have such in save-cli

honestly, I don't understand why we need yarn.lock in save-cli: it doesn't have JS executable artifact, only as a library (and it's a pure kotlin app). Will create an issue for it (if we need the yarn.lock, will create a task for it as in save-cloud),

And still it can fail: even in save-cloud, the task kotlinUpgradeYarnLock is separate and if JS dependency changed by upgrading the kolin (as we see it here) -- it fails

@kgevorkyan
Copy link
Member

honestly, I don't understand why we need yarn.lock in save-cli: it doesn't have JS executable artifact, only as a library (and it's a pure kotlin app). Will create an issue for it (if we need the yarn.lock, will create a task for it as in save-cloud),

@petertrr, may be you can remember this?

And still it can fail: even in save-cloud, the task kotlinUpgradeYarnLock is separate and if JS dependency changed by upgrading the kolin (as we see it here) -- it fails

can we unify updates in JS and in kotlinUpgradeYarnLock into the single action for renovate bot?

@nulls
Copy link
Member

nulls commented Apr 3, 2023

can we unify updates in JS and in kotlinUpgradeYarnLock into the single action for renovate bot?

probably, yes we can, added as a comment to the created issue

@nulls nulls merged commit 811e9d2 into main Apr 3, 2023
@nulls nulls deleted the renovate/core-kotlin branch April 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants