Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate signing stuff. #3

Merged
merged 2 commits into from
Jun 6, 2012

Conversation

hoverlover
Copy link
Contributor

I cannot take much credit for this commit. Most of it was taken from @carnesmedia's Savon fork. I made one bug fix (DigestValue out of order) and the rest of the work I did was simply porting the changes over to Akami, since the original author's changes were based when Akami was still a part of Savon.

There are no specs for these changes. I feel bad about this, but there are two reasons:

  1. @carnesmedia's fork did have specs, but they were written while it was part of Savon. These specs simply don't work under Akami due to missing classes from Savon, among other things.
  2. I made these changes out of necessity for something I'm working on for a client, and am a little under the gun to get this up and running, so I didn't have the time to make the specs work under Akami. I know, lame excuse, but that's the truth.

I've tested these changes with some live requests, and it does work. If you don't want to accept the pull request without specs, it will at least serve to let others know about my fork if they need certificate signing in conjunction with Savon/Akami. I will hopefully have time in the near future to get the specs working and pushed.

@@ -0,0 +1,82 @@
module Akami
class WSSE
# This canonicalizer uses XMLStarlet (http://xmlstar.sourceforge.net/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: I think Nokogiri has real canonicalization support now...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I will look into that.

rubiii added a commit that referenced this pull request Jun 6, 2012
@rubiii rubiii merged commit ef7336e into savonrb:master Jun 6, 2012
@sunny sunny mentioned this pull request Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants