-
Notifications
You must be signed in to change notification settings - Fork 54
Closed
Description
Hey I’ve been looking through this code as I’m using this with home assistant and have been having problems connecting to my switchbots. I am also seeing bluepy helper processes hanging around.
It seems this code should call disconnect after write packet success or failure. I know the bluepy peripheral class destructor should call disconnect but it seems this isn’t always the case as stated in the bluepy docs. I would propose calling disconnect at the end of writing.
Also with the retry logic, is there a reason that the retry should not also cover situations where connect fails?
Thanks!
nemccarthy
Metadata
Metadata
Assignees
Labels
No labels