Skip to content

Fix plug stale state while connected #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix plug stale state while connected #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions switchbot/devices/plug.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
"""Library to handle connection with Switchbot."""
from __future__ import annotations

from .device import REQ_HEADER, SwitchbotDevice
from .device import REQ_HEADER, SwitchbotDeviceOverrideStateDuringConnection

# Plug Mini keys
PLUG_ON_KEY = f"{REQ_HEADER}50010180"
PLUG_OFF_KEY = f"{REQ_HEADER}50010100"


class SwitchbotPlugMini(SwitchbotDevice):
class SwitchbotPlugMini(SwitchbotDeviceOverrideStateDuringConnection):
"""Representation of a Switchbot plug mini."""

async def update(self, interface: int | None = None) -> None:
Expand All @@ -18,12 +18,18 @@ async def update(self, interface: int | None = None) -> None:
async def turn_on(self) -> bool:
"""Turn device on."""
result = await self._send_command(PLUG_ON_KEY)
return self._check_command_result(result, 1, {0x80})
ret = self._check_command_result(result, 1, {0x80})
self._override_adv_data = {"isOn": True}
self._fire_callbacks()
return ret

async def turn_off(self) -> bool:
"""Turn device off."""
result = await self._send_command(PLUG_OFF_KEY)
return self._check_command_result(result, 1, {0x00})
ret = self._check_command_result(result, 1, {0x80})
self._override_adv_data = {"isOn": False}
self._fire_callbacks()
return ret

def is_on(self) -> bool | None:
"""Return switch state from cache."""
Expand Down