Skip to content

Handle invalid basic data #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Handle invalid basic data #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion switchbot/devices/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ async def _lock_unlock(
# Also update the battery and firmware version
if basic_data := await self._get_basic_info():
self._last_full_update = time.monotonic()
self._update_parsed_data(self._parse_basic_data(basic_data))
if len(basic_data) >= 3:
self._update_parsed_data(self._parse_basic_data(basic_data))
else:
_LOGGER.warning("Invalid basic data received: %s", basic_data)
self._fire_callbacks()

return status
Expand Down