Skip to content

Conversation

RenierM26
Copy link
Contributor

Bluepy development seems to be stale and plagued by custom code to underlying bluez component.

It might be worth it to rather use something like Bleak? The development is active and it's an asyncio library that seems to work much better.

@RenierM26 RenierM26 marked this pull request as draft October 30, 2021 06:13
@RenierM26 RenierM26 marked this pull request as ready for review October 30, 2021 12:28
@RenierM26 RenierM26 changed the title Suggestion to change library from bluepy to Bleak Suggestion to change library from bluepy to Bleak (with async) Oct 30, 2021
@RenierM26 RenierM26 changed the title Suggestion to change library from bluepy to Bleak (with async) *Suggestion* to change library from bluepy to Bleak (with async) Nov 6, 2021
@RenierM26 RenierM26 marked this pull request as draft November 7, 2021 14:38
@Danielhiversen
Copy link
Collaborator

Agree that Bleak is much better to work with.
You have my support on this 👍

@RenierM26 RenierM26 changed the title *Suggestion* to change library from bluepy to Bleak (with async) *in progress* to change library from bluepy to Bleak (with async) May 15, 2022
@RenierM26 RenierM26 force-pushed the bleak_api_conversion branch from 634ae10 to f0aff75 Compare May 15, 2022 05:41
@RenierM26 RenierM26 marked this pull request as ready for review May 21, 2022 12:04
@RenierM26
Copy link
Contributor Author

Hi @Danielhiversen,

The bleak conversion to pyswitchbot is finally ready for review.

@RenierM26 RenierM26 changed the title *in progress* to change library from bluepy to Bleak (with async) Change library from bluepy to Bleak (with async) May 21, 2022
Copy link
Collaborator

@Danielhiversen Danielhiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@Danielhiversen Danielhiversen merged commit dbc9d52 into sblibs:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants