Skip to content

Timeout when unable to connect to device after 40 seconds. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 21, 2022
Merged

Timeout when unable to connect to device after 40 seconds. #40

merged 19 commits into from
Feb 21, 2022

Conversation

RenierM26
Copy link
Contributor

@RenierM26 RenierM26 commented Feb 19, 2022 •
edited
Loading

  • Improve handling of disc state.
  • Default Connection timeout, instead of bluepy default, if unable to connect to device after 40 seconds.

@RenierM26 RenierM26 mentioned this pull request Feb 19, 2022
Closed
@RenierM26 RenierM26 marked this pull request as draft February 19, 2022 19:28
@RenierM26 RenierM26 marked this pull request as ready for review February 20, 2022 07:43
@Danielhiversen Danielhiversen merged commit 23efbec into sblibs:master Feb 21, 2022
@pascalwinters
Copy link

pascalwinters commented Feb 22, 2022 •
edited
Loading

[copied to related PR]
@RenierM26 For me it's stable since the beginning of using this fix. Two remarks/questions:

  1. Maybe it's good, to mark this line as DEBUG:
    2022-02-20 11:12:40 WARNING (SyncWorker_2) [switchbot] Bluepy busy, waiting before retry

  2. I'm missing the log of reading each (I mean) 60 seconds the current status. Is this log event deleted?

@heisenberg2980
Copy link

@RenierM26 @pascalwinters as this has already been merged, do we need to open a PR for HA?

@pascalwinters
Copy link

@RenierM26 @pascalwinters as this has already been merged, do we need to open a PR for HA?

No, it’s aleady done and merged 😉
home-assistant/core#67025

@heisenberg2980 heisenberg2980 mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RenierM26 @pascalwinters @heisenberg2980 @Danielhiversen