Skip to content

Use an asyncio.Future for commands instead of a sleep #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use an asyncio.Future for commands instead of a sleep #52

wants to merge 2 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 26, 2022 •
edited
Loading

Speeds up sending commands

2022-07-25 22:16:23.775 DEBUG (MainThread) [switchbot] Subscribe to notifications
2022-07-25 22:16:23.826 DEBUG (MainThread) [switchbot] Sending command, 570102
2022-07-25 22:16:23.858 INFO (MainThread) [switchbot] Notification received: bytearray(b'\x05\xff\x00')
2022-07-25 22:16:23.858 DEBUG (MainThread) [switchbot] UnSubscribe to notifications

@bdraco bdraco marked this pull request as ready for review July 26, 2022 08:16
@bdraco bdraco mentioned this pull request Jul 26, 2022
Merged
@bdraco bdraco force-pushed the future_for_commands branch from 0cd4dd0 to 68828bd Compare July 26, 2022 19:38
@bdraco bdraco mentioned this pull request Jul 29, 2022
Merged
@bdraco
Copy link
Member Author

bdraco commented Jul 29, 2022 •
edited
Loading

Merged into #54 since it will conflict

@bdraco bdraco closed this Jul 29, 2022
@bdraco bdraco mentioned this pull request Jul 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco