Skip to content

fix: reject advertisement updates that are missing data if we already have it #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2022
Merged

fix: reject advertisement updates that are missing data if we already have it #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion switchbot/devices/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,10 @@ def get_battery_percent(self) -> Any:

def update_from_advertisement(self, advertisement: SwitchBotAdvertisement) -> None:
"""Update device data from advertisement."""
self._sb_adv_data = advertisement
# Only accept advertisements if the data is not missing
# if we already have an advertisement with data
if advertisement.data.get("data") or not self._sb_adv_data.data.get("data"):
self._sb_adv_data = advertisement
self._override_adv_data = None
if self._device and ble_device_has_changed(self._device, advertisement.device):
self._cached_services = None
Expand Down