[1.3.x] Fix IO.getModifiedTimeOrZero for unnormalized paths #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref scala/scala#8528 Currently SDKMAN blocks for prompt when there's a new version of SDKMAN. This is an attempted workaround.
The fix for long path names on windows, 099aa4f, had the unintended side effect of causing IO.getModifiedTimeOrZero to throw uncaught IOExceptions when the path name was not normalized. Specifically, it would throw if the path was empty or if it had relative components. To fix this, we try to get the modified time but if the file is not found, we normalize the path and make it absolute and retry. This change was primarily made for windows, but it turns out that IO.getModifiedTimeOrZero(file("")) also didn't work correctly. Naively, I'd expect the empty path to be expanded to the program working directory but it would actually just return 0 because the posix native api did not handle empty strings either. Relative paths did work on posix before this change.
|
This failed on Travis CI macOS job. I'm going to restart and see if it passes. |
|
@eatkins I'm going to merge this. |
|
My bad. The review request notification slipped through the cracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #273
Fixes sbt/sbt#5224
original description
The fix for long path names on windows,
099aa4f, had the unintended side effect
of causing IO.getModifiedTimeOrZero to throw uncaught IOExceptions when
the path name was not normalized. Specifically, it would throw if the
path was empty or if it had relative components. To fix this, we try to
get the modified time but if the file is not found, we normalize the
path and make it absolute and retry.
This change was primarily made for windows, but it turns out that
IO.getModifiedTimeOrZero(file("")) also didn't work correctly. Naively,
I'd expect the empty path to be expanded to the program working
directory but it would actually just return 0 because the posix native
api did not handle empty strings either. Relative paths did work on
posix before this change.