Make RichFile a value class #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Jun 26, 2017
|
Why are we making this a value class? |
|
It's an enrich-my-type/syntax class, so we can avoid allocation. |
|
I get that it tries but I'm not sure if it's worth it for non primitive
types given JITing.
Now you have code gen by the compiler.
|
|
It's a 1 line source code change, that has the effect of transforming new RichFile(f).existsinto RichFile.extension$exists(f)Looks like a good trade-off, to me. |
|
I was wondering why sbt/sbt couldn't just bump IO to latest, and realized that this change broke bincompat, so it needs to propagate to all modules first. |
|
Yes, that is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.