Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependencies as JARs for force proper manifests (fixes #60) #64

Merged
merged 1 commit into from
Dec 8, 2018

Conversation

lefou
Copy link
Contributor

@lefou lefou commented Dec 5, 2018

This fixes #60.

This PR contains the same fixes as PR #61, but without adding the flaky integration test. #61 was reverted because of these flaky tests.

@lefou
Copy link
Contributor Author

lefou commented Dec 5, 2018

Review by @johanandren

@lefou
Copy link
Contributor Author

lefou commented Dec 5, 2018

The Travis build failed, because oraclejdk10 is deprecated. But it succeeded for oraclejdk8.

@atooni
Copy link

atooni commented Dec 7, 2018

This PR comes from our team building a scala/akka based integration framework at https://github.com/woq-blended/blended. We are using a snapshot version with the patch in our own build. It works perfectly well in our set up and all bundles we generate using the patched version work as expected.

From our perspective the PR is good to merge and works as expected.

This having said, we follow a slightly different approach in our setup than most other projects we have seen. On other projects we often see that a Scala class within the project folder is used to contribute the setting for a feature (i.e. OSGi) for ALL configured subprojects. As a result, an individual sub project usually consists of the basic setup + n contributions.

We have chosen to have 1 file / subproject and configure all the features for a subproject in one place - using helper classes to abstract away common settings where it makes sense. We do the same for OSGi and we do find that keeps our setup quite clean.

FYI: http://woq-blended.github.io/blended/BUILDING.html

@lefou
Copy link
Contributor Author

lefou commented Dec 7, 2018

I thought, the decision to merge this PR was already made (see #61), but later reverted because of the (known) flaky integration test, which I left out this time.

@johanandren
Copy link
Contributor

We asked for a second opinion from the people who have contributed to the OSGi support in Akka, but I interpret this as good to go:

From our perspective the PR is good to merge and works as expected.

Thanks for the extra check @atooni

@johanandren johanandren merged commit 2658d06 into sbt:master Dec 8, 2018
@lefou
Copy link
Contributor Author

lefou commented Mar 29, 2019

Can we get a new release, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing imported versions for packages from project dependencies
3 participants