Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing providerOptions gasLimit and allowUnlimitedContractSize to override defaults #494

Conversation

jjgonecrypto
Copy link
Contributor

By allowing providerOptions.gasLimit be included in .solcover.js, it allows us at Synthetix to avoid these Exceeds block gas limit errors, see : https://travis-ci.org/github/Synthetixio/synthetix/jobs/672297483#L2100-L2148.

Note: I added support for allowUnlimitedContractSize as well cause I was in there and it seemed prudent

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #494 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          20       20           
  Lines         790      790           
=======================================
  Hits          784      784           
  Misses          6        6           
Impacted Files Coverage Δ
lib/api.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff50bb9...123d421. Read the comment docs.

@cgewecke cgewecke self-requested a review April 10, 2020 01:30
Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks so much @justinjmoses! Makes sense.

@cgewecke cgewecke merged commit 90843ff into sc-forks:master Apr 10, 2020
@jjgonecrypto
Copy link
Contributor Author

Thanks Chris. Could you publish 0.7.4 when you get a chance? 🙏

@jjgonecrypto jjgonecrypto deleted the no-override-gas-limit-from-provider-options branch April 10, 2020 01:46
@cgewecke
Copy link
Member

@justinjmoses Yes will publish tonight - there's just one other thing I have throw in first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants