Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Coverage Measurements #502

Merged
merged 31 commits into from
Apr 26, 2022
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Apr 22, 2020

Note
This branch is periodically published as a beta. To install run:

npm install solidity-coverage@beta

The current release notes are here

Staging PR for 0.8.x Phase II: #411

TODO

Logical OR branch coverage (#499)

  • Unit test cases
  • truffle/buidler integration test case
  • Support require/assert
  • Support while
  • Support return
  • Support if/else
  • Check html for highlighting correctness.

Ternary Conditionals (#587)

  • Restore unit test cases
  • New instrumentation
  • Check html for highlighting correctness.

Modifier-by-method Coverage (#588)

Test Matrix Option (#593)

Public Variable Coverage (#598, #600)

  • Unit test cases
  • E2E test w/ codechecks
  • Track interface changes
  • Markdown report

Documentation Coverage

All

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #502 into master will increase coverage by 0.04%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   99.25%   99.30%   +0.04%     
==========================================
  Files          20       20              
  Lines         810      864      +54     
==========================================
+ Hits          804      858      +54     
  Misses          6        6              
Impacted Files Coverage Δ
lib/parse.js 96.96% <95.45%> (+0.58%) ⬆️
lib/coverage.js 100.00% <100.00%> (ø)
lib/injector.js 100.00% <100.00%> (ø)
lib/instrumenter.js 100.00% <100.00%> (ø)
lib/registrar.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655fb79...1ebbd95. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #502 (498b8cd) into master (b641167) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   98.96%   99.17%   +0.21%     
==========================================
  Files          22       23       +1     
  Lines         962     1218     +256     
==========================================
+ Hits          952     1208     +256     
  Misses         10       10              
Impacted Files Coverage Δ
lib/validator.js 100.00% <ø> (ø)
plugins/resources/nomiclabs.ui.js 100.00% <ø> (ø)
plugins/resources/truffle.ui.js 100.00% <ø> (ø)
lib/abi.js 100.00% <100.00%> (ø)
lib/api.js 100.00% <100.00%> (ø)
lib/collector.js 100.00% <100.00%> (ø)
lib/coverage.js 100.00% <100.00%> (ø)
lib/injector.js 100.00% <100.00%> (ø)
lib/instrumenter.js 100.00% <100.00%> (ø)
lib/parse.js 97.24% <100.00%> (+0.69%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b641167...498b8cd. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #502 (f84e1da) into 0.8.0-restructure (5174ecd) will decrease coverage by 13.43%.
The diff coverage is 90.49%.

@@                  Coverage Diff                   @@
##           0.8.0-restructure     #502       +/-   ##
======================================================
- Coverage              98.69%   85.26%   -13.44%     
======================================================
  Files                     22       21        -1     
  Lines                    999     1201      +202     
======================================================
+ Hits                     986     1024       +38     
- Misses                    13      177      +164     
Impacted Files Coverage Δ
lib/validator.js 100.00% <ø> (ø)
plugins/resources/nomiclabs.ui.js 100.00% <ø> (ø)
plugins/resources/truffle.ui.js 100.00% <ø> (ø)
plugins/truffle.plugin.js 12.50% <0.00%> (-87.50%) ⬇️
plugins/resources/truffle.utils.js 9.30% <5.26%> (-90.70%) ⬇️
lib/abi.js 100.00% <100.00%> (ø)
lib/api.js 98.17% <100.00%> (-1.83%) ⬇️
lib/collector.js 100.00% <100.00%> (ø)
lib/coverage.js 100.00% <100.00%> (ø)
lib/injector.js 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5174ecd...f84e1da. Read the comment docs.

@cgewecke cgewecke changed the base branch from master to 0.8.0-restructure April 26, 2022 03:24
@cgewecke cgewecke marked this pull request as ready for review April 26, 2022 03:33
@cgewecke cgewecke merged commit 0bf470a into 0.8.0-restructure Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants