Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gasEstimation example. Pin dev Truffle to 3.2.5 for now. #53

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Jun 30, 2017

I'm holding off on merging this because I removed the migrations.js require warning from the README assuming 3.3.1 fixed everything but it seems to still be a problem. Will revisit tomorrow.

@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files           6        6           
  Lines         330      330           
  Branches       78       78           
=======================================
  Hits          322      322           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa41e80...8b627fa. Read the comment docs.

@cgewecke cgewecke changed the title Add gasEstimation example, clear CI cache to bump truffle to 3.3 Add gasEstimation example, bump Truffle in CI to 3.3 Jun 30, 2017
@cgewecke
Copy link
Member Author

Also: why is the external require unit-test passing? Something's not right here.

@cgewecke cgewecke changed the title Add gasEstimation example, bump Truffle in CI to 3.3 Add gasEstimation example. Pin dev Truffle to 3.2.5 for now. Jul 3, 2017
@cgewecke cgewecke merged commit a738fd4 into master Jul 3, 2017
@cgewecke cgewecke deleted the readme-gas-example branch July 3, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants