fix: visibility of icons in IntegerInput

[kevinjoshi46b]

Solves #319

The input icons now look like this:

* here:

$, Ξ here:

and similar for # in byte input

[damianmarti]

LGTM!

[carletex]

@kevinjoshi46b The idea of having daisy themes is to use those colors (primary, secondary, accent, neutral, etc) so they always look consistent if you change your theme colors in tailwind.config.js.

If we hardcode a color, like text-gray-400, you are "disconnecting" it from the theme.

From DaisyUI:
.

So we need to use a color from the theme (maybe we need to re-think colors in there)

Also, for me, it's not that bad how they look currently:

cc @damianmarti @technophile-04

[kevinjoshi46b]

If we hardcode a color, like text-gray-400, you are "disconnecting" it from the theme.

Alright ya this is a good point.

Also, for me, it's not that bad how they look currently:

Maybe the * is fine because its a more dense icon (but it would probably still go unnoticed maybe on a bigger screen) what about Ξ ?

So we need to use a color from the theme (maybe we need to re-think colors in there)

Ya I do feel this might be needed since the colors are too close and not too contradicting.

Would like to know others opinions too.

[carletex]

Maybe the * is fine because its a more dense icon (but it would probably still go unnoticed maybe on a bigger screen) what about Ξ ?

If you are refering to the "Ξ" in EtherInput, the problem is that it's using "text-primary" color... and it should be "text-accent" (like the "*" in the value-wei input).

If we want more contrast, we can use "text-neutral".

[technophile-04]

Maybe the * is fine because its a more dense icon (but it would probably still go unnoticed maybe on a bigger screen)

I feel they are visible in main branch, like I have a kind of big monitor screen and looks great their too...we also had improved their accessibility before check #170

what about Ξ ?

Yeah, as Carlos mentioned nice catch it can be improved and should have been text-accent....lol text-neutral a bit too contrasty and kind off misses the theme so I would go with text-accent but its just my personal preference 😂

[kevinjoshi46b]

I feel they are visible in main branch, like I have a kind of big monitor screen and looks great their too...

That's great not an issue there then

text-neutral a bit too contrasty

Ohhh yes, its brighter then the input number itself :)

I majorly noticed this issue in Ξ and then just ended up changing the rest as well assuming they have a similar issue but ya it seems like just changing from text-accent -> text-primary is good enough.

[carletex]

@kevinjoshi46b You did it the other way around.

You changed "text-accent" to "text-primary" in integer & bytes inputs, and left the Ξ as it was. Now I can barely see them.

primary:

accent:

It's the other way around. You just need to change the Ξ color inside the EtherInput to "text-accent"

[kevinjoshi46b]

You changed "text-accent" to "text-primary" in integer & bytes inputs, and left the Ξ as it was. Now I can barely see them.

Oops, my bad sorry for the inconvenience