fix(contract.ts): improve missing config check

[sverps]

Description

Rather than just check if deployedContracts is null, this improves the behavior to check if there is a contract definition for the network selected in scaffold.config.ts. This results in fewer type errors when a contract might have been deployed on some network, but locally a user only has the file generated for another network.

Related Issues

Fixes #371

[technophile-04]

Tysm @sverps 🙌, but I think I am kind of neutral on this because I would love to see an error when I deploy my contract to sepolia and my frontend is pointing to goerli.

With this fix I deployed my contract to sepolia and pointed my frontend to mainnet and I see no error for contractReads/Write even when you run yarn next:types no errors are shown this means while deploying too it would get easily deployed even though I am pointing to mainnet and don't have any contract on it.

Yup this fix will be beginner friendly also the TS error message { contractName: string; functionName: string; } is not good but I would prefer to get an error if am doing something wrong 😅

---

An idea : What if we log a message like "Make sure you update the chain to seplolia in scaffold.config.ts" after you run deploy to avoid situations like #371, since now we run our custom script in the end :

scaffold-eth-2/packages/hardhat/deploy/99_generateTsAbis.ts

Line 76 in e77565c

console.log(`📝 Updated TypeScript contract definition file on ${TARGET_DIR}deployedContracts.ts`);

[sverps]

When you run the frontend without a deployed contract on the chain you configured, it already properly informs you of it, right? For beginners, I think that is slightly preferred over some console warning or error that could easily get overlooked.

But it's not entirely clear-cut either. So I'm okay with exploring this discussion a bit further.

[technophile-04]

If you run frontend without a deployed contract on the chain you configured

Screen.Recording.2023-06-13.at.11.36.30.AM.mov

People get this popup if they use useScaffold hooks

---

Regarding types error

Screen.Recording.2023-06-13.at.11.32.27.AM.mov

As we can see we don't get any error on this branch even if we have a missing deployed contract for that chain.

---

But it's not entirely clear-cut either.

+++

I mean I am completely fine with the current fix and it makes sense, but I am kind of leaning towards showing good ts-error(which will be tough) instead of not showing the error itself but yeah current fix also makes sense!! since the ts-error is not beginner friendly

[sverps]

#378 seems to have the same issue (awaiting confirmation from issue creator)

@technophile-04 I'd like to merge this PR to avoid blocking users with non-intuitive errors.

[technophile-04]

blocking users with non-intuitive errors

Yeah I agree, people might spend time in the wrong direction while debugging due to non-intuitive errors so lets merge, Tysm @sverps for the fix 🙌