Solidity Optimizer options

[moltam89]

Description

Hey guys,

This PR is about the Solidity compiler's Optimizer.

It is enabled by default in the original scaffold-eth repo.
I wasn't sure if I should just enable it for scaffold-eth-2 as well, or not. I decided to only add it as an option and update the readme, to let people know about this, before they deploy to a Live network.

Let me know what do you think.

Best,
Tamas

Additional Information

• I have read the contributing docs (if this is your first contribution)
• This is not a duplicate of any existing pull request

[technophile-04]

Tysm @moltam89 🙌

After doing some research here's my opinion :

TLDR;

We should set optimizer to enabled : true

So for recent versions of Solidity, we would recommend to always use the optimizer unless you really do not care about gas costs.
~ Official solidity lang QNA 2020

---

Short Desc on what optimizer does :

• First optimizer is not hardhat feature (lol I thought previously) but it comes with solidity compiler itself.Deployment costs and function call costs are two areas where the compiler optimizer impacts smart contracts gas.
• There are several steps that the optimizer performs. A simple example would be evaluating expressions whose value is known at runtime, e.g., x + 0 is evaluated to x, where x may be a parameter known only during runtime. For more desc checkout solidity docs secion

For runs parameter checkout this answer

[moltam89]

Hey @technophile-04 ,

Yeah, I think you're right and we should enable the Optimiser by default.

I've updated and rebased the PR.

Cheers,
Tamas

[technophile-04]

Tysm @moltam89 🙌, cc @carletex , @sverps , @damianmarti for final thoughts before we merge this, here is the TLDR; -> #360 (comment)

[carletex]

I'm up for enabling it by default!

A nitpick:

// By default, the Solidity Optimizer is enabled
// https://docs.soliditylang.org/en/latest/internals/optimizer.html#benefits-of-optimizing-solidity-code
// https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options
// https://hardhat.org/hardhat-runner/docs/config

Isn't this too much? haha

// By default, the Solidity Optimizer is enabled This seems redundant (easily inferred from optimizer: { enabled: true} :D). And maybe we don't need 3 links? I feel that the important part is the "runs" parameter, so some helper text with a link could help there (move the https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options link right above "runs"?)

Anyway, everything looks good, just suggesting some tiny tweaks.

Thanks!

[technophile-04]

// By default, the Solidity Optimizer is enabled This seems redundant (easily inferred from optimizer: { enabled: true} :D). And maybe we don't need 3 links? I feel that the important part is the "runs" parameter, so some helper text with a link could help there (move the https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options link right above "runs"?)

Yes yes, I agree with this

Tysm @moltam89 just pushed the changes Carlos suggested at aef0a99

Also tested that deployment and verification work correctly 🙌

https://sepolia.etherscan.io/address/0x786b4Dff292876aD3aDE9CCD534373AEa1Ad8eD7#code

[moltam89]

Thank you guys!