allow overrides in useScaffoldContractWrite

[technophile-04]

Description

deployContracts.ts is empty :

This does problem does not show up if the deployedContract.ts is empty.

Non empty deployedContracts :

1.) It seems that typescript complains when you try to pass overrides to useScafffoldContractWrite :

2.) Also another small problem is if people pass in value as normal arg(ETH value string) and overrides : {gasLimit : BigNumber.from("210000")} it will call contract with 0 value since we have omitted field value in overrides, checkout the logic below this line

scaffold-eth-2/packages/nextjs/hooks/scaffold-eth/useScaffoldContractWrite.ts

Line 42 in dd5082c

value: value ? utils.parseEther(value) : undefined,

Originally mentioned in #336

Additional Information

Proposed solution :

1). Fixing types :
Passed in "recklesslyUnprepared" argument to UseContractWriteConfig generic type : UseContractWriteConfig<"recklesslyUnprepared">

Reason - It seems that wagmi kind of use Union discriminators for getting UseContractWriteConfig type checkout ->
this line on wagmi implementation.

Passing "recklesslyUnprepared" to generic helps typescript to correctly grab PartialBy< WriteContractUnpreparedArgs<TAbi, TFunctionName>, 'abi' | 'address' | 'args' | 'functionName' > this part of Union discriminator since that is what we want.

**2.) Spreaded overrides and resConfig separately checkout f32ebbf

Doubt

I am kind of bit confused why TS does no complain on passing overrides when deployedContract.ts is empty.

My guess is that its something to do with keys mentioned in Omit which is causing it to pick Prepared branch of Union discriminator but don't know if that's true

scaffold-eth-2/packages/nextjs/utils/scaffold-eth/contract.ts

Line 116 in dd5082c

TAbiStateMutability extends ReadAbiStateMutability ? UseContractReadConfig : UseContractWriteConfig,

Reason for doubting above line since this the type being used when deployedContract.ts in non-empty.

---

• I have read the contributing docs (if this is your first contribution)
• This is not a duplicate of any existing pull request

Related Issues

None

Please feel free to correct me if I missed something / close this PR in case of better approach 🙌

[technophile-04]

cc @sverps, can we merge this? I think the solution of passing in "recklesslyUnprepared" argument to UseContractWriteConfig generic type makes sense and is minimal since we are deterministically using "recklesslyUnprepared" in our useContractWrite hook 🙌

[sverps]

Yes, good fix 👍

(Will get resolved with the viem refactor, but we can merge this already in the meantime)