Fixing flaky test #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to it and gets falsified in property testing
julienrf
approved these changes
Jan 15, 2018
This was referenced Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a particularly flaky test in our set of exercises, regarding the Type Classes section. This exercises expects a function to perform an ordering in a list of rational numbers. As there are multiple versions of this function that could return a correct answer, our property testing is getting falsified results almost all runs (as it tries to offer false answers and will fail if a correct response is given).
Lacking a better solution, in this case I'm changing this test to use a straightforward application instead, to avoid issues with future changes and deployments.