Integrates sbt-org-policies plugin #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
Mar 28, 2017
julienrf
reviewed
Mar 29, 2017
| def creationAndManipulation(res0: String): Unit = { | ||
| val aliceAccount = new BankAccount | ||
| val c3 = Note("C", "Quarter", 3) | ||
| val c3 = Note("C", "Quarter", 3) |
There was a problem hiding this comment.
I’m not sure that aligning definitions like so actually improves readability…
There was a problem hiding this comment.
Agreed, it was just a proposal for code formatting. We just wanted to have a tool to automatize the code formatting.
Please, feel free to modify the code style here: https://github.com/scala-exercises/exercises-scalatutorial/blob/master/.scalafmt.conf
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration has no effect on the deployed application since we are releasing a snapshot new version.
There are multiples changes across the source code, most of them due to scalafmt autoformatting or file headers. The important changes here are:
Please, @raulraja could you review? Thanks!