Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit page links doesnt work #286

Open
xhudik opened this issue May 13, 2021 · 2 comments
Open

Edit page links doesnt work #286

xhudik opened this issue May 13, 2021 · 2 comments

Comments

@xhudik
Copy link
Contributor

xhudik commented May 13, 2021

Very page(e.g. https://www.scala-exercises.org/std_lib/partial_functions ) at the bottom has Edit Exercisepage link:
image

This link doenst work:

#it points to
https://github.com/scala-exercises/exercises-stdlib/edit/master/src/main/scala/stdlib/PatternMatching.scala
#it should points to instead
https://github.com/scala-exercises/exercises-stdlib/edit/main/src/main/scala/stdlib/PatternMatching.scala

(replace main with master)

I'd create a pull request just didnt find where the link actually is located :)

@juanpedromoreno
Copy link
Contributor

Thanks @xhudik , I guess we need to update the server side

@corentinmb
Copy link

corentinmb commented Nov 26, 2021

It's seems the fix doesn't work, for example access an exercise: https://www.scala-exercises.org/std_lib/type_signatures
The button Edit exercises send to: https://github.com/scala-exercises/exercises-stdlib/edit/master/src/main/scala/stdlib/TypeSignatures.scala

But the button View on Github works, but i don't know how because when I hover the button it send it to the master branch:
image

but when I click, send me here: https://github.com/scala-exercises/exercises-stdlib/blob/main/src/main/scala/stdlib/TypeSignatures.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants