Upgrade to Scala.js 0.6.15. #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fix the warnings related to private constructors of native JS classes. However, we disable the deprecations related to `@JSGlobal` in the facades, and those related to `@JSExport` on top-level objects in the example project. Those will be addressed later.
We choose not to reorganize imports to minimize the diff. However that means we'll have to manually import `@JSGlobal` where necessary after applying the scalafix rewrite. Note: we do not actually apply the rewrite just yet, so that this commit serves as documentation for Scala.js users.
Imports are updated manually. Everything else comes straight from scalafix, without manual intervention. We remove the compiler option that disregards the warnings, since it's all been fixed.
This reverts commit 0d1d295. After having applied the rewrites, we do not need scalafix anymore, so we can remove it.
sjrd
force-pushed
the
upgrade-scalajs-0.6.15
branch
from
7c2b426 to
ba149fc
Compare
We also remove the compiler option that disards the relevant warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains everything involved in upgrading to Scala.js 0.6.15, piecemeal.
The first commit does the upgrade itself, and configures the compiler to ignore warnings related to major deprecations.
The next 3 commits use scalafix to automatically migrate facades to using
@JSGlobal.The last commit migrates the examples to use
@JSExportTopLevelinstead of@JSExporton top-level objects.