Skip to content

Fix the result type of a few methods in SVGTextContentElement to Double. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Fix the result type of a few methods in SVGTextContentElement to Double. #341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bbe27a
Wrong type in method. Int should be Double
georgeorfanidi Nov 26, 2018
d57ec52
Update Svg.scala
georgeorfanidi Nov 26, 2018
76eb150
Update Svg.scala
georgeorfanidi Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/scala/org/scalajs/dom/raw/Svg.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,15 +1895,15 @@ abstract class SVGTextContentElement

def getExtentOfChar(charnum: Int): SVGRect = js.native

def getComputedTextLength(): Int = js.native
def getComputedTextLength(): Double = js.native

def getSubStringLength(charnum: Int, nchars: Int): Int = js.native
def getSubStringLength(charnum: Int, nchars: Int): Double = js.native

def selectSubString(charnum: Int, nchars: Int): Unit = js.native

def getNumberOfChars(): Int = js.native

def getRotationOfChar(charnum: Int): Int = js.native
def getRotationOfChar(charnum: Int): Double = js.native

def getEndPositionOfChar(charnum: Int): SVGPoint = js.native
}
Expand Down