Skip to content

Add Node.baseURI #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2021
Merged

Add Node.baseURI #559

merged 1 commit into from
Sep 5, 2021

Conversation

AugustNagro
Copy link
Contributor

Fixes #444

armanbilge
armanbilge approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, much appreciated!

@armanbilge armanbilge requested a review from japgolly September 5, 2021 20:33
@AugustNagro
Copy link
Contributor Author

Thanks, I appreciate you and Japgolly maintaining the project, looking forward to the scala 3 version!

@japgolly
Copy link
Contributor

japgolly commented Sep 5, 2021

LGTM, thank you for the contribution @AugustNagro !! Not long to 2.0 now!! 🎉

@japgolly japgolly merged commit 65f8a3f into scala-js:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@japgolly japgolly Awaiting requested review from japgolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Node.baseURI
3 participants
@AugustNagro @japgolly @armanbilge