Implement parts of java.util.logging #2
Conversation
| @@ -1,9 +1,9 @@ | |||
| # scalajs-java-logging | |||
|
|
|||
| [](https://travis-ci.org/scala-js/scala-js-java-logging) | |||
| [](https://www.scala-js.org/) | |||
| [](https://www.scala-js.org/) | |||
There was a problem hiding this comment.
You should not change this.
There was a problem hiding this comment.
The svg for 6.9 is missing. I guess the solution is to add that badge to scala-js
There was a problem hiding this comment.
@cquiroz You are actually right to change it to 0.6.8. But ideally that would be in a separate PR, as it irrelevant to this PR.
|
That is all. Otherwise LGTM. |
|
Is it ok to add my name to the list of developers? |
Good question. According to https://maven.apache.org/pom.html#Developers, I don't think you should. They say:
From that paragraph, I interpret the term "developer" more as "maintainer", i.e., people who are in charge of the repository. If we had a list of "contributors", that would be a good spot to add your name. As it happens, we have a perfectly accurate and up to date contributor list at https://github.com/scala-js/scala-js-java-logging/graphs/contributors, where you'll clearly appear as the main contributor as soon as this PR gets merged :-) |
cquiroz
force-pushed
the
java-util-logging-implementation
branch
from
3c2ffd2 to
b67c752
Compare
|
Updated with comments from @nicolasstucki |
| assertNull(record.getThrown) | ||
| } | ||
|
|
||
|
|
|
That is all. |
|
I'm squashing my updates right away, but perhaps it is easier to review if I only commit the fixes and the squash at the end. Any preference? |
|
It is fine if you squash. |
cquiroz
force-pushed
the
java-util-logging-implementation
branch
from
b67c752 to
1069234
Compare
|
Updated with the last comments, thanks! |
|
LGTM |
This PR contains an implementation of large part of the java util logging package. This PR was submitted to scala-js as scala-js/scala-js#2410