Upgrade to sbt 0.13.13, Scala 2.12.0 and Scala.js 0.6.13. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Nov 22, 2016
| - sbt ++$TRAVIS_SCALA_VERSION +testSuiteJVM/test | ||
| - sbt ++$TRAVIS_SCALA_VERSION +testSuite/test | ||
| - sbt ++$TRAVIS_SCALA_VERSION 'set scalaJSStage in Global := FullOptStage' +testSuite/test | ||
| - sbt ++$TRAVIS_SCALA_VERSION +publishLocal |
There was a problem hiding this comment.
Do not use + in Travis scripts. The cross-testing is achieved by Travis' matrix.
| @@ -5,6 +5,7 @@ val commonSettings: Seq[Setting[_]] = Seq( | |||
| version := "0.1.1-SNAPSHOT", | |||
| organization := "org.scala-js", | |||
| scalaVersion := "2.11.8", | |||
| crossScalaVersions := Seq("2.10.4", "2.11.8", "2.12.0"), | |||
There was a problem hiding this comment.
crossScalaVersions should be in ThisBuild at the top-level of the .sbt file, like this:
import sbt.Keys._
import org.scalajs.sbtplugin.cross.CrossProject
crossScalaVersions in ThisBuild := Seq("2.10.4", "2.11.8", "2.12.0")
val commonSettings: Seq[Setting[_]] = Seq(
...
cquiroz
force-pushed
the
upgrade_scala_2.12
branch
from
86aaf48 to
4888523
Compare
|
Updated as requested |
cquiroz
force-pushed
the
upgrade_scala_2.12
branch
from
4888523 to
e201a78
Compare
sjrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build to do cross build across Scala 2.10, 2.11 and 2.12 as well as upgrading scala.js to version 0.6.13