Fix #23: Bug in Instant.toString #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where an extra `:00` would be added to the `toString` if the seconds field is 0 but the nanos field is not.
|
Thanks for your contribution. |
|
@sjrd Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where an extra
:00would be added to thetoStringif theseconds field is 0 but the nanos field is not.
Also, there seems to be an issue when running the tests locally. If I run the tests it is fine, but if I modify the source code (not the tests) then when I go to run the tests I get several "non existent methods" error.
After that happens I have to clean my targets
git clean -xfdbefore I can run the tests again. Modifying the tests do not cause said issue to occur.