Skip to content

FF ONLY Towards 1.3.1. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

FF ONLY Towards 1.3.1. #22

merged 1 commit into from
Jan 31, 2022

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Jan 30, 2022

No description provided.

@gzm0 gzm0 marked this pull request as draft January 30, 2022 13:22
@gzm0
Copy link
Contributor Author

gzm0 commented Jan 30, 2022

Needs to wait for release :)

sjrd
sjrd requested changes Jan 30, 2022
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should remove the mimaBinaryIssueFilters in the test kit project.

@gzm0 gzm0 marked this pull request as ready for review January 31, 2022 05:47
@gzm0
Copy link
Contributor Author

gzm0 commented Jan 31, 2022

I have left the imports for Mima. LMK if you'd like me to remove them as well.

@gzm0 gzm0 merged commit 9d46d49 into scala-js:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzm0 @sjrd