Update documentation to reflect (anticipated) v0.5.0 #38
Conversation
|
@sjrd thank you for comments & review. |
| @@ -224,7 +233,7 @@ if the result will always be the same (e.g., `document`), and `def` when | |||
| subsequent accesses to the field might return a different value (e.g., | |||
| `innerWidth`). | |||
|
|
|||
| Use `Unit` instead of `js.Undefined` as result type of methods that do not | |||
| Use `Unit` instead of `js.prim.Undefined` as result type of methods that do not | |||
| return any value. | |||
There was a problem hiding this comment.
This paragraph can be restated, saying that Scala primitive types should be used instead of js.prim._, with possibly using scala.Int where applicable (stress that Int is to be used only if the value is in the range of an Int, 32-bits; if an integer value may be out of that range -which is typically the case for time values-, Double must be used -and not Long).
|
That's all for this diff. |
|
Updated |
|
LGTM |
|
It can wait so we have a full update at once. I'll add a commit with a new page about the SBT-plugin showing:
Anything else that should go in there? |
|
Not that I think of right now, at least. |
|
The |
|
Added new commit. Review by @sjrd |
| lazy val root = project.in(file(".")).aggregate() | ||
|
|
||
| lazy val fooJS = project.in(file("foo-js")).settings(scalaJSSettings: _*).settings( | ||
| name := "Foo Js Build", |
There was a problem hiding this comment.
Give projects same name and say why
|
That is all for this commit. |
|
Updated |
|
LGTM so far. |
|
What would you like me to add? |
|
A link from And still dreaming about a Getting Started Guide ^^ But maybe I should do that one. |
|
The link from |
Ah right. Somehow I missed it.
OK |
|
Could you add named anchors to sections of the tutorial, for example I'd like to refer to specific portions of the tutorial from the release notes. |
|
OK. We really need a better system. This is getting way out of hand; we shouldn't need to care about these kind of things. |
| Hello world! | ||
| [success] (...) | ||
|
|
||
| Congratulations! You have successfully compiled and run your first Scala.js application. The code is actually run by a JavaScript interpreter. If you do not believe this (it happens to us occainally), you can use sbt's `last`: |
|
The section Get started in |
|
|
||
| ### Create the HTML Page | ||
|
|
||
| The only thing which is specific to Scala.js, is how we can call the Scala code from JavaScript. First have a look at our HTML page (`scalajs-tutorial-fastopt.html`), we will go in the details right after. |
There was a problem hiding this comment.
you could be a bit clearer about which folder this file goes into, I think.
| </html> | ||
| {% endhighlight %} | ||
|
|
||
| The first script tag simply includes the generated code (attention, you might need to adapt the Scala version from `2.10` to `2.11` here). |
There was a problem hiding this comment.
from 2.11 to 2.10 here if you use Scala 2.10.x instead of 2.11.x
|
That's all for me. |
|
btw, highlighting works as expected (I built it locally to review it) |
|
Updated |
Also fixes scala-js#37: Document how to cross build
|
Updated |
|
Updated |
|
LGTM |
|
Tutorial has 0.5.0 branch now. Waiting for travis |
Update documentation to reflect (anticipated) v0.5.0
First draft for documentation update. A separate SBT-plugin page will follow.