Fix #505: Add info about Scala.js 0.6.x' End of Life. #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was mostly obsolete, does not actually answer *frequently* asked questions, and was way too short to cover real questions.
gzm0
approved these changes
Jul 15, 2020
| @@ -30,6 +30,7 @@ Use [scalajs-bundler](https://scalacenter.github.io/scalajs-bundler/) instead. | |||
| Instead, it is provided by [sbt-jsdependencies](https://github.com/scala-js/jsdependencies). | |||
|
|
|||
| The rest of this section applies to Scala.js 0.6.x only. | |||
| [Scala.js 0.6.x has reached End of Life.]({{ BASE_PATH }}/doc/internals/scalajs-0.6.x-eol.html) | |||
There was a problem hiding this comment.
Instead of this, I propose we completely remove the "Deprecated: Depending on JavaScript libraries" section (and maybe add a basic intro to scalajs-bundler)?
I now realize that this is probably better done in another PR.
There was a problem hiding this comment.
Yes, more generally, I'd like to only show docs for 1.x by default, and have a checkbox to show information related to 0.6.x. A lightweight variant of versioned docs, in some sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.