Skip to content

Announcing Scala.js 1.5.1. #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Announcing Scala.js 1.5.1. #541

merged 1 commit into from
Apr 1, 2021

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Mar 31, 2021

No description provided.

@sjrd sjrd requested a review from gzm0 March 31, 2021 12:38
* It is forward binary compatible with 1.5.0: libraries compiled with 1.5.1 can be used with 1.5.0 without change.
* It is backward source compatible with 1.5.0: source code that used to compile with 1.5.0 should compile as is when upgrading to 1.5.1.

From Scala.js 1.5.0, which was a **minor** release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this fragment here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I copy-pasted that from the 1.3.1 announcement. It's supposed to mean that this section is "inherited" from the release notes 1.5.0.

Perhaps instead

In addition, like Scala.js 1.5.0:

?

Or just remove that section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is value in keeping that section, because it makes the release notes stand on their own: They define the compatibility guarantees w.r.t. any Scala.js version. "In addition, like Scala.js 1.5.0:" is good IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

* It is forward binary compatible with 1.5.0: libraries compiled with 1.5.1 can be used with 1.5.0 without change.
* It is backward source compatible with 1.5.0: source code that used to compile with 1.5.0 should compile as is when upgrading to 1.5.1.

From Scala.js 1.5.0, which was a **minor** release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is value in keeping that section, because it makes the release notes stand on their own: They define the compatibility guarantees w.r.t. any Scala.js version. "In addition, like Scala.js 1.5.0:" is good IMO.

From Scala.js 1.5.0, which was a **minor** release:

* It is *not* forward binary compatible with 1.4.x: libraries compiled with 1.5.1 cannot be used with 1.4.x or earlier.
* It is *not* entirely backward source compatible: it is not guaranteed that a codebase will compile *as is* when upgrading from 1.4.x or earlier (in particular in the presence of `-Xfatal-warnings`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put "In addition, like Scala.js 1.5.0:", maybe add "... backward source compatible with 1.4.x:" to be more explicit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :)

@sjrd sjrd merged commit c6a5aa6 into scala-js:master Apr 1, 2021
@sjrd sjrd deleted the scalajs-1.5.1 branch April 1, 2021 07:54

## Bug fixes

Among others, the following bugs have been fixed in 1.5.0:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it mention 1.5.0 in release notes for 1.5.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is a typo. (fix #542).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants