-
Notifications
You must be signed in to change notification settings - Fork 147
Announcing Scala.js 1.5.1. #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* It is forward binary compatible with 1.5.0: libraries compiled with 1.5.1 can be used with 1.5.0 without change. | ||
* It is backward source compatible with 1.5.0: source code that used to compile with 1.5.0 should compile as is when upgrading to 1.5.1. | ||
|
||
From Scala.js 1.5.0, which was a **minor** release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this fragment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I copy-pasted that from the 1.3.1 announcement. It's supposed to mean that this section is "inherited" from the release notes 1.5.0.
Perhaps instead
In addition, like Scala.js 1.5.0:
?
Or just remove that section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is value in keeping that section, because it makes the release notes stand on their own: They define the compatibility guarantees w.r.t. any Scala.js version. "In addition, like Scala.js 1.5.0:" is good IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* It is forward binary compatible with 1.5.0: libraries compiled with 1.5.1 can be used with 1.5.0 without change. | ||
* It is backward source compatible with 1.5.0: source code that used to compile with 1.5.0 should compile as is when upgrading to 1.5.1. | ||
|
||
From Scala.js 1.5.0, which was a **minor** release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is value in keeping that section, because it makes the release notes stand on their own: They define the compatibility guarantees w.r.t. any Scala.js version. "In addition, like Scala.js 1.5.0:" is good IMO.
From Scala.js 1.5.0, which was a **minor** release: | ||
|
||
* It is *not* forward binary compatible with 1.4.x: libraries compiled with 1.5.1 cannot be used with 1.4.x or earlier. | ||
* It is *not* entirely backward source compatible: it is not guaranteed that a codebase will compile *as is* when upgrading from 1.4.x or earlier (in particular in the presence of `-Xfatal-warnings`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you put "In addition, like Scala.js 1.5.0:", maybe add "... backward source compatible with 1.4.x:" to be more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point :)
|
||
## Bug fixes | ||
|
||
Among others, the following bugs have been fixed in 1.5.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it mention 1.5.0 in release notes for 1.5.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is a typo. (fix #542).
No description provided.