Skip to content

Upgrade to sbt 1.9.0. #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Upgrade to sbt 1.9.0. #4827

merged 1 commit into from
Jun 4, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Mar 8, 2023

sbt 1.9.0 contains the new sbt plugin publishing mechanism. It dual-publishes sbt plugins with Ivy-style paths (invalid in Maven, although it works out when released from sbt) and valid Maven paths.

See sbt/sbt#3410 and sbt/sbt#7096.

@sjrd sjrd changed the title WiP Upgrade to sbt 1.9.0-M1. For CI only. Upgrade to sbt 1.9.0. Jun 2, 2023
@sjrd sjrd marked this pull request as ready for review June 2, 2023 15:58
@sjrd sjrd requested a review from gzm0 June 2, 2023 15:58
@sjrd
Copy link
Member Author

sjrd commented Jun 2, 2023

sbt 1.9.0 final is now released, so this is ready for review.

@@ -1 +1 @@
sbt.version=1.5.8
sbt.version=1.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we upgrade sbt here? IIUC in sbt-test, we're sticking to the oldest version of sbt to ensure support?

The evolution seems to be:
1.5.4: 8ccd35c (1.5.x supports dotty natively)
1.5.8: abc3069 (fix log4j bug)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed. I blindly followed the last commit that touched project/build.properties, but indeed there's no reason to update in the test for this change.

Updated.

sbt 1.9.0 contains the new sbt plugin publishing mechanism. It
dual-publishes sbt plugins with Ivy-style paths (invalid in Maven,
although it works out when released from sbt) and valid Maven paths.

See sbt/sbt#3410 and
sbt/sbt#7096.
@sjrd sjrd requested a review from gzm0 June 3, 2023 08:18
@gzm0 gzm0 merged commit ac8fc4e into scala-js:main Jun 4, 2023
@sjrd sjrd deleted the sbt-1.9.0 branch June 4, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants