Skip to content

Fix swallowing exceptions inside loop #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2020
Merged

Fix swallowing exceptions inside loop #10

merged 2 commits into from
Jan 9, 2020

Conversation

lolgab
Copy link
Collaborator

@lolgab lolgab commented Nov 24, 2019 •
edited
Loading

Fixes #9

@lolgab lolgab requested a review from rwhaling November 24, 2019 10:41
@lolgab lolgab force-pushed the fix-exceptions-swallowing branch from 80d44f3 to 36f41a2 Compare November 24, 2019 10:49
@lolgab lolgab force-pushed the fix-exceptions-swallowing branch from 36f41a2 to 8eccfb3 Compare November 24, 2019 10:49
rwhaling
rwhaling approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@rwhaling rwhaling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwhaling rwhaling merged commit 7fca336 into master Jan 9, 2020
@lolgab lolgab deleted the fix-exceptions-swallowing branch July 25, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwhaling rwhaling rwhaling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loop run hides exceptions
2 participants
@lolgab @rwhaling